Provide full resources in archived items finished webhooks #1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include full resources with expireAt (as string) in crawlFinished and uploadFinished webhook notifications rather than using the downloadUrls field (this is retained for collections). - Set default presigned duration to just short of 1 week and enforce maximum supported by S3 - Update tests
ikreymer
reviewed
Oct 23, 2023
backend/btrixcloud/basecrawls.py
Outdated
| self.presign_duration_seconds = ( | ||
| int(os.environ.get("PRESIGN_DURATION_MINUTES", 60)) * 60 | ||
| presign_duration_seconds = ( | ||
| int(os.environ.get("PRESIGN_DURATION_MINUTES", PRESIGN_MINUTES_DEFAULT)) |
There was a problem hiding this comment.
We also have:
PRESIGN_DURATION_MINUTES: "{{ .Values.storage_presign_duration_minutes | default 60 }}"
in configmap.yaml so that will take precedence. probably should keep this default in one place only to avoid confusion, can make the env var blank by default
There was a problem hiding this comment.
oh, I see its been updated to latest value, but should it be blank there perhaps?
ikreymer
reviewed
Oct 23, 2023
- set default minutes in code, if omitted in chart - add commented out value to chart - use minutes as maximum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1306
resourceswith expireAt (as string) in crawlFinished and uploadFinished webhook notifications rather than using thedownloadUrlsfield (this is retained for collections).Tested locally and on dev