Send email to superuser when background job fails #1355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we add additional types of background jobs that don't have the same fields, will have to do this a bit differently. For now we can assume all jobs have the same fields.
tw4l
changed the title
ikreymer
approved these changes
Nov 9, 2023
ikreymer
reviewed
Nov 9, 2023
| ) | ||
| superuser = await self.user_manager.get_superuser() | ||
| org = await self.org_ops.get_org_by_id(job.oid) | ||
| self.email.send_background_job_failed(job, org, finished, superuser.email) |
There was a problem hiding this comment.
Just in case, should wrap this in run_in_executor() so it doesn't block the async event loop handling for the operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1344
Sends email to superadmin when a background job fails.
Sample email (from operator logs, from job that failed because of invalid replica s3 bucket secret access key):