Skip to content

Quick fix: hoist tooltips in archived item list #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Quick fix: hoist tooltips in archived item list #1738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions frontend/src/features/archived-items/archived-item-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,17 @@ export class ArchivedItemListItem extends TailwindElement {
typeIcon = "upload";
}

const notApplicable = html`<sl-tooltip content=${msg("Not applicable")}>
const notApplicable = html`<sl-tooltip
hoist
content=${msg("Not applicable")}
>
<sl-icon
name="slash"
class="text-base text-neutral-400"
label=${msg("Not applicable")}
></sl-icon>
</sl-tooltip>`;
const none = html`<sl-tooltip content=${msg("None")}>
const none = html`<sl-tooltip hoist content=${msg("None")}>
<sl-icon
name="slash"
class="text-base text-neutral-400"
Expand Down Expand Up @@ -152,6 +155,7 @@ export class ArchivedItemListItem extends TailwindElement {
content=${msg(str`${typeLabel}: ${crawlStatus.label}`)}
@sl-hide=${(e: SlHideEvent) => e.stopPropagation()}
@sl-after-hide=${(e: SlHideEvent) => e.stopPropagation()}
hoist
>
<sl-icon
class="text-base"
Expand All @@ -162,6 +166,7 @@ export class ArchivedItemListItem extends TailwindElement {
</sl-tooltip>
`}
<sl-tooltip
hoist
content=${activeQAStats
? msg(
str`QA Analysis: ${qaStatus.label} (${activeProgress}% finished)`,
Expand Down Expand Up @@ -217,6 +222,7 @@ export class ArchivedItemListItem extends TailwindElement {
<sl-tooltip
content=${msg(str`By ${this.item.userName}`)}
@click=${this.onTooltipClick}
hoist
>
<sl-format-date
lang=${getLocale()}
Expand All @@ -232,6 +238,7 @@ export class ArchivedItemListItem extends TailwindElement {
</btrix-table-cell>
<btrix-table-cell>
<sl-tooltip
hoist
content=${formatNumber(this.item.fileSize || 0, {
style: "unit",
unit: "byte",
Expand All @@ -250,6 +257,7 @@ export class ArchivedItemListItem extends TailwindElement {
${isUpload
? notApplicable
: html`<sl-tooltip
hoist
@click=${this.onTooltipClick}
content=${msg(
str`${formatNumber(
Expand All @@ -273,6 +281,7 @@ export class ArchivedItemListItem extends TailwindElement {
: lastQAStarted && qaRunCount
? html`
<sl-tooltip
hoist
content=${msg(
str`Last run started on ${formatISODateString(lastQAStarted)}`,
)}
Expand All @@ -290,6 +299,7 @@ export class ArchivedItemListItem extends TailwindElement {
${isUpload
? notApplicable
: html`<sl-tooltip
hoist
@click=${this.onTooltipClick}
content=${this.item.reviewStatus
? msg(
Expand Down