feat: Add tag constraints #3006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@emma-sg Open to the name of the component if you have other ideas? |
emma-sg
reviewed
Nov 24, 2025
emma-sg
approved these changes
Nov 24, 2025
Member
emma-sg
left a comment
emma-sg
left a comment
There was a problem hiding this comment.
Left a few comments/requests, but I don't think they're necessarily blockers if you want to get this merged sooner! This is a nice improvement & I know it unblocks some further list view work.
Member
|
Nice, looks great! |
SuaYoo
merged commit 22a33b4
into
frontend-browser-profile-ui-enhancements
29 checks passed
SuaYoo
deleted the
frontend-browser-profile-ui-enhancements--fix-tags
branch
SuaYoo
added a commit
that referenced
this pull request
Nov 26, 2025
- Limits tag input to 40 characters - Determines maximum tags displayed by container width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2992
Changes
Manual testing
Screenshots