Fix POST /orgs/{oid}/crawls/delete #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw4l
force-pushed
the
issue-284-delete-crawls
branch
from
d8ade99 to
51d7021
Compare
tw4l
force-pushed
the
issue-284-delete-crawls
branch
2 times, most recently
from
0829e3e to
dfc7311
Compare
tw4l
force-pushed
the
issue-284-delete-crawls
branch
3 times, most recently
from
ab35b13 to
b8b2537
Compare
- Add permissions check to ensure crawler users can only delete their own crawls - Fix broken endpoint - Delete files from storage as well as deleting crawl from db - Add tests, including nightly test that ensures crawl files are no longer accessible after the crawl is deleted
tw4l
force-pushed
the
issue-284-delete-crawls
branch
from
b8b2537 to
48a1f19
Compare
tw4l
force-pushed
the
issue-284-delete-crawls
branch
from
22f7db1 to
899e1da
Compare
|
@ikreymer the intermittently failing test is fixed (ran k3d CI jobs 4 times to make sure) and this is now ready for review |
ikreymer
approved these changes
Feb 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #284
The nightly test (which checks the database as well as verifying that files are no longer available for download after crawl deletion) was run in this workflow and passed before I moved it back to nightly: https://github.com/webrecorder/browsertrix-cloud/actions/runs/4177896196/jobs/7236029282#step:14:21