Skip to content
This repository was archived by the owner on Aug 23, 2022. It is now read-only.

Conversation

@k0nserv
Copy link
Member

@k0nserv k0nserv commented May 25, 2022

This test started failing, seemingly, due to something external
changing. Making a branch from the last green build and an empty commit
causes the same failure.

There might be something here, but for now I've just disabled the test.

This test started failing, seemingly, due to something external
changing. Making a branch from the last green build and an empty commit
causes the same failure.

There might be something here, but for now I've just disabled the test.
@k0nserv
Copy link
Member Author

k0nserv commented May 25, 2022

Attempted to re-run CI with the same code that last passed was in #28.

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #29 (bdf7eed) into main (73f4e28) will decrease coverage by 15.43%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #29       +/-   ##
===========================================
- Coverage   60.55%   45.12%   -15.44%     
===========================================
  Files          39       39               
  Lines        6369     9470     +3101     
  Branches     1816     2622      +806     
===========================================
+ Hits         3857     4273      +416     
- Misses        819     3281     +2462     
- Partials     1693     1916      +223     
Impacted Files Coverage Δ
src/mdns/mdns_test.rs 63.10% <ø> (ø)
src/lib.rs 15.25% <0.00%> (-84.75%) ⬇️
src/error.rs 3.09% <0.00%> (-0.35%) ⬇️
src/agent/agent_selector.rs 54.42% <0.00%> (-0.33%) ⬇️
src/candidate/candidate_base.rs 79.92% <0.00%> (-0.08%) ⬇️
src/agent/agent_internal.rs 62.73% <0.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73f4e28...bdf7eed. Read the comment docs.

@k0nserv k0nserv merged commit efaaa18 into main May 25, 2022
@k0nserv k0nserv deleted the disable-failing-windows-test branch May 25, 2022 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants