bugfix-Udp connection not close (reopen #174) #195 #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0nserv
reviewed
Jun 17, 2022
melekes
approved these changes
Jun 20, 2022
| let sctp_association = loop { | ||
| tokio::select! { | ||
| _ = self.notify_tx.notified() => { | ||
| // It seems like notify_tx is only notified on Stop so perhaps this check |
Contributor
There was a problem hiding this comment.
if this is the case, then we should definitely refactor
k0nserv
approved these changes
Jun 20, 2022
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
+ Coverage 43.58% 43.60% +0.01%
==========================================
Files 68 68
Lines 9505 9502 -3
Branches 2735 2739 +4
==========================================
Hits 4143 4143
+ Misses 3373 3370 -3
Partials 1989 1989
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a pr forked from webrtc-rs/webrtc master(0.4.0) branch, to fix a udp connection not closing issue
please refer to this issue for details