make getStats code better in FF65+ #1087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-ivar
approved these changes
Aug 7, 2018
|
Ping @fippo Can you rebase this? |
the code currently accesses a stats report.timestamp which triggers the warnings described in https://blog.mozilla.org/webrtc/getstats-isremote-65/ Also adds the isRemote checks. While remote outbound-rtp can not happen when using sender.getStats() people might copy this technique and apply to pc.getStats() so it is better to show
|
i was about to say "pong" :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the code currently accesses a stats report.timestamp which
triggers the warnings described in
https://blog.mozilla.org/webrtc/getstats-isremote-65/
Also adds the isRemote checks. While remote outbound-rtp
can not happen when using sender.getStats() people might
copy this technique and apply to pc.getStats() so it is
better to show
from discussion with @jan-ivar