Upgrade openssl dependency to 0.9.7 #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asayers
commented
Mar 3, 2017
| WebSocketStream::Tcp(ref inner) => WebSocketStream::Tcp(try!(inner.try_clone())), | ||
| WebSocketStream::Ssl(ref inner) => WebSocketStream::Ssl(try!(inner.try_clone())), | ||
| // FIXME: This is **terrible**! But SslStream no longer has try_clone... | ||
| WebSocketStream::Ssl(ref inner) => WebSocketStream::Tcp(try!(inner.get_ref().try_clone())), |
Collaborator
There was a problem hiding this comment.
Yeah I know that problem exactly. 😢
I've been thinking about how to fix it and I think just to disallow separating for SSL
Collaborator
Author
|
Great! I guess I can close this PR now then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to upgrade the openssl dependency to the latest, to allow rust-websocket to be used alongside other crates which also depend on openssl. The upgrade was mostly straightforward, but I did hit one snag:
SslStreamno longer implementstry_clone, which makes implementing it forWebSocketStreamproblematic. Apparently rustls'ClientSessionalso doesn't provide atry_clone.This PR breaks secure websockets; I'm not suggesting you merge it as-is - just asking for suggestions.