上传文件接口支持自定义meta字段 #103
Merged
上传文件接口支持自定义meta字段 #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lianup
commented
Jan 12, 2022
lianup
commented
- 增加uploadFile接口，支持自定义meta
- 去除comment_on_pr.yml
EmmetZC
requested changes
Jan 12, 2022
src/main/java/com/wechat/pay/contrib/apache/httpclient/WechatPayUploadHttpPost.java
Show resolved
Hide resolved
src/main/java/com/wechat/pay/contrib/apache/httpclient/WechatPayUploadHttpPost.java
Outdated
Show resolved
Hide resolved
src/main/java/com/wechat/pay/contrib/apache/httpclient/WechatPayUploadHttpPost.java
Outdated
Show resolved
Hide resolved
|
|
||
| public Builder(URI uri) { | ||
| if (uri == null) { | ||
| throw new IllegalArgumentException("缺少上传图片接口URL"); |
Contributor
There was a problem hiding this comment.
用了File之后，不一定是图片了。
src/main/java/com/wechat/pay/contrib/apache/httpclient/WechatPayUploadHttpPost.java
Show resolved
Hide resolved
Eric-Lee-Handyman
approved these changes
Jan 13, 2022
Closed
xy-peng
reviewed
Jan 13, 2022
| setFileContentType(fileName); | ||
| this.meta = String.format("{\"filename\":\"%s\",\"sha256\":\"%s\"}", fileName, fileSha256); | ||
| return this; | ||
| } |
Contributor
There was a problem hiding this comment.
为什么不实现成
string meta = String.format("{\"filename\":\"%s\",\"sha256\":\"%s\"}", fileName, fileSha256);
return withFile(fileName, meta, inputStream);
Contributor
Author
There was a problem hiding this comment.
从逻辑的角度，withImage调用wtihFile来实现更合理。已修改
xy-peng
reviewed
Jan 13, 2022
|
|
||
| if (uri == null) { | ||
| throw new IllegalArgumentException("缺少上传图片接口URL"); | ||
| if (meta == null || meta.isEmpty()) { |
Contributor
There was a problem hiding this comment.
这些检查还是需要吧，除了fileSha256之外。开发者要是忘记调用withFile()或者withImage()就调用build()是要报错的哦。请再参考标准的builder实现。
Contributor
There was a problem hiding this comment.
现在虽然我们的设计meta就意味着有其他参数，但是未来可能放开了呢？
Contributor
Author
There was a problem hiding this comment.
有道理。之前没有考虑未来放开的场景，已修改。
xy-peng
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.