Improving filter control #5583

djhvscf · 2021-02-08T18:30:03Z

Improving filter control extension

Default options:

Column options:

Scenarios

When height is not set //input
When height is set // input
When height is not set // select
When height is set // select
When height is not set // datetimepicker
When height is set // datetimepicker
Show Columns when height is not set
Show Columns when height is set

Integrations

Cookie integration
~~MultipleSelect with basic configuration~~
~~MultipleSelect when height is set (Facing css issue. See Improving filter control #5583 (comment))~~
~~MultipleSelect when height is not set~~
~~MultipleSelect when multiple is set (Facing css issue. See Improving filter control #5583 (comment))~~

Update docs

Add/Remove documentation

…m/wenzhixin/bootstrap-table into feature/multiselect-filtercontrol

Show Columns when height is set

djhvscf · 2021-03-15T22:51:08Z

@wenzhixin @DustinUtecht Hey guys, I'm planning to remove the datepicker stuff (that depends on a third party library ) and use the html5 control.. what do you think?

UtechtDustin · 2021-03-16T08:21:48Z

Its fine for me, we should avoid third party libraries as much as we can.

djhvscf · 2021-04-18T00:21:59Z

@wenzhixin @UtechtDustin can you please help me with this CSS issue?

yeezy69 · 2021-12-04T21:26:48Z

Sorry, I have to annoy you again ;-) I use a page with two tables. The tables have columns with identical names.

The search in the first (domains) table works fine. When searching in the second (zones) table for "ID" and "User", the search-string disappears from the input fields. When searching in "Zone" column no problem.

table for explanation:

<table id="tableDomains" data-ajax="ajaxRequestDomains" data-side-pagination="server" data-filter-control="true">
    <thead>
        <tr>
            <th data-field="id" data-filter-control="input">ID</th>
            <th data-field="user_name" data-filter-control="input">User</th>
            <th data-field="domain_name" data-filter-control="input">Domain</th>
        </tr>
    </thead>
</table>

<table id="tableZones" data-ajax="ajaxRequestZones" data-side-pagination="server" data-filter-control="true">
    <thead>
        <tr>
            <th data-field="id" data-filter-control="input">ID</th>
            <th data-field="user_name" data-filter-control="input">User</th>
            <th data-field="zone_name" data-filter-control="input">Zone</th>
        </tr>
    </thead>
</table>

I suspect this is missing a table-id check?

djhvscf · 2021-12-05T02:57:37Z

Sorry, I have to annoy you again ;-) I use a page with two tables. The tables have columns with identical names.

The search in the first (domains) table works fine. When searching in the second (zones) table for "ID" and "User", the search-string disappears from the input fields. When searching in "Zone" column no problem.

table for explanation:
<table id="tableDomains" data-ajax="ajaxRequestDomains" data-side-pagination="server" data-filter-control="true">
    <thead>
        <tr>
            <th data-field="id" data-filter-control="input">ID</th>
            <th data-field="user_name" data-filter-control="input">User</th>
            <th data-field="domain_name" data-filter-control="input">Domain</th>
        </tr>
    </thead>
</table>

<table id="tableZones" data-ajax="ajaxRequestZones" data-side-pagination="server" data-filter-control="true">
    <thead>
        <tr>
            <th data-field="id" data-filter-control="input">ID</th>
            <th data-field="user_name" data-filter-control="input">User</th>
            <th data-field="zone_name" data-filter-control="input">Zone</th>
        </tr>
    </thead>
</table>
I suspect this is missing a table-id check?

Probably yes. I'm going to review that

djhvscf · 2021-12-05T16:06:58Z

Sorry, I have to annoy you again ;-) I use a page with two tables. The tables have columns with identical names.
The search in the first (domains) table works fine. When searching in the second (zones) table for "ID" and "User", the search-string disappears from the input fields. When searching in "Zone" column no problem.
table for explanation:
<table id="tableDomains" data-ajax="ajaxRequestDomains" data-side-pagination="server" data-filter-control="true">
    <thead>
        <tr>
            <th data-field="id" data-filter-control="input">ID</th>
            <th data-field="user_name" data-filter-control="input">User</th>
            <th data-field="domain_name" data-filter-control="input">Domain</th>
        </tr>
    </thead>
</table>

<table id="tableZones" data-ajax="ajaxRequestZones" data-side-pagination="server" data-filter-control="true">
    <thead>
        <tr>
            <th data-field="id" data-filter-control="input">ID</th>
            <th data-field="user_name" data-filter-control="input">User</th>
            <th data-field="zone_name" data-filter-control="input">Zone</th>
        </tr>
    </thead>
</table>
I suspect this is missing a table-id check?
Probably yes. I'm going to review that

Can you create an example using our online editor? @yeezy69 I can't reproduce it locally

yeezy69 · 2021-12-05T18:17:39Z

Can you create an example using our online editor? @yeezy69 I can't reproduce it locally

Just search in the second table: https://live.bootstrap-table.com/code/yeezy69/9864

sdespont · 2021-12-09T07:20:20Z

Can you create an example using our online editor? @yeezy69 I can't reproduce it locally

Just search in the second table: https://live.bootstrap-table.com/code/yeezy69/9864

The example provided permits to reproduce the problem. The table is well sorted, but the searching string disappear :

djhvscf · 2021-12-12T17:04:35Z

Can you create an example using our online editor? @yeezy69 I can't reproduce it locally

Just search in the second table: https://live.bootstrap-table.com/code/yeezy69/9864

The example provided permits to reproduce the problem. The table is well sorted, but the searching string disappear :

This is still in progress.

sdespont · 2021-12-20T07:25:09Z

@djhvscf Except the last bug above, is the branch feature/multiselect-filtercontrol stable enough to be used in production?

djhvscf · 2021-12-20T18:50:33Z

Yes, it is

sdespont · 2021-12-21T11:24:19Z

@djhvscf OK, thanks for the reply. The dist folder of the feature/multiselect-filtercontrol branch is using the old version. Is there a link of a built version of bootstrap-table-filter-control.js ? Maybe a release can be done because you have fixed a lot of things in this branch?

UtechtDustin · 2021-12-21T11:30:35Z

@djhvscf OK, thanks for the reply. The dist folder of the feature/multiselect-filtercontrol branch is using the old version. Is there a link of a built version of bootstrap-table-filter-control.js ? Maybe a release can be done because you have fixed a lot of things in this branch?

The dist folder will be updatet on a new release, but never for a new branch.
You can build it youreself by run the build script with e.g. yarn yarn build.

sdespont · 2022-02-08T07:35:58Z

Hi there 👋, is there plan to release this PR in the next weeks?

wenzhixin · 2022-02-09T10:51:56Z

@UtechtDustin I have improved some codes. I think we can merge this PR now.

djhvscf · 2022-02-18T06:20:28Z

@wenzhixin @UtechtDustin thanks guys! I have been kind of busy because I have a new baby and you know.. we need to sleep, feed him and so

UtechtDustin · 2022-02-18T09:13:09Z

@wenzhixin @UtechtDustin thanks guys! I have been kind of busy because I have a new baby and you know.. we need to sleep, feed him and so

Congrats!
I can totally understand that, my son is coming in june and we are building a house right now.
Unfortunately I aldo don't have that much time right now.

djhvscf added 2 commits February 6, 2021 20:21

Re writing the extension

9abdb40

Improving extension

3e0b9cf

djhvscf mentioned this pull request Feb 8, 2021

Multiple select in filter-control #3298

Open

djhvscf added 9 commits February 9, 2021 22:38

Merge branch 'develop' into feature/multiselect-filtercontrol

9e37c9b

Fix caret position

dd54d89

Merge branch 'feature/multiselect-filtercontrol' of https://github.co…

a5bd395

…m/wenzhixin/bootstrap-table into feature/multiselect-filtercontrol

Improving select option when the header is set

d90bebe

Merge branch 'develop' into feature/multiselect-filtercontrol

21d62c9

Merge branch 'develop' into feature/multiselect-filtercontrol

277b665

Merge branch 'feature/multiselect-filtercontrol' of https://github.co…

c30a293

…m/wenzhixin/bootstrap-table into feature/multiselect-filtercontrol

Show Columns when height is not set

5898ec2

Show Columns when height is set

Fix showFilterControlSwitch

c7c93fd

djhvscf added 4 commits March 20, 2021 22:03

Using htlm5 datepicker

ef57135

Merge branch 'develop' into feature/multiselect-filtercontrol

740b2ea

Improving extension

da0db68

Merge branch 'develop' into feature/multiselect-filtercontrol

68e461a

UtechtDustin mentioned this pull request Mar 31, 2021

data-filter-control="select" #5664

Closed

djhvscf added 6 commits April 1, 2021 19:47

Merge branch 'develop' into feature/multiselect-filtercontrol

3a3227b

Fixing issue with filterControlContainer

903f2b1

Adding multipleselect configuration

5a0fc9e

Multipleselect with height no set

3a2f3e2

Able to filter by multiple values using multipleselect control

3bbccf1

Merge branch 'develop' into feature/multiselect-filtercontrol

40b21fe

Fixing some issues with cookie

95fe29b

djhvscf mentioned this pull request Dec 5, 2021

Fix first time search with cookie and filter-control #5982

Closed

10 tasks

djhvscf added 2 commits December 9, 2021 10:46

Merge branch 'develop' into feature/multiselect-filtercontrol

f02d2c3

Merge branch 'develop' into feature/multiselect-filtercontrol

0e9e512

UtechtDustin mentioned this pull request Dec 22, 2021

Filter select controls do not populate when data height defined #6004

Closed

Merge branch 'develop' into feature/multiselect-filtercontrol

6c5beb5

blt950 mentioned this pull request Feb 5, 2022

bootstrap-table reset filter-control Vatsim-Scandinavia/controlcenter#377

Closed

wenzhixin added 4 commits February 8, 2022 21:18

Merge branch 'develop' into feature/multiselect-filtercontrol

e9bd193

Resolve conversations

69ccb28

Merge branch 'develop' into feature/multiselect-filtercontrol

e489cce

Fixed the css problem

bf9b6db

wenzhixin approved these changes Feb 9, 2022

View reviewed changes

wenzhixin merged commit 55a1a6f into develop Feb 10, 2022

wenzhixin deleted the feature/multiselect-filtercontrol branch February 10, 2022 11:49

wenzhixin mentioned this pull request Mar 12, 2022

Input filter control gets lost value after reloading data #6030

Open

sdespont mentioned this pull request May 18, 2022

Filter control : searching text disappears when 2 tables or more are displayed on the same view #6166

Closed

UtechtDustin mentioned this pull request Jun 8, 2023

hideUnusedSelectOptions Option is still active ? #6740

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improving filter control #5583

Improving filter control #5583

djhvscf commented Feb 8, 2021 •

edited by UtechtDustin

djhvscf commented Mar 15, 2021

UtechtDustin commented Mar 16, 2021

djhvscf commented Apr 18, 2021

yeezy69 commented Dec 4, 2021

djhvscf commented Dec 5, 2021

djhvscf commented Dec 5, 2021

yeezy69 commented Dec 5, 2021

sdespont commented Dec 9, 2021

djhvscf commented Dec 12, 2021

sdespont commented Dec 20, 2021

djhvscf commented Dec 20, 2021

sdespont commented Dec 21, 2021

UtechtDustin commented Dec 21, 2021

sdespont commented Feb 8, 2022

wenzhixin commented Feb 9, 2022

djhvscf commented Feb 18, 2022

UtechtDustin commented Feb 18, 2022

Improving filter control #5583

Improving filter control #5583

Conversation

djhvscf commented Feb 8, 2021 • edited by UtechtDustin

djhvscf commented Mar 15, 2021

UtechtDustin commented Mar 16, 2021

djhvscf commented Apr 18, 2021

yeezy69 commented Dec 4, 2021

djhvscf commented Dec 5, 2021

djhvscf commented Dec 5, 2021

yeezy69 commented Dec 5, 2021

sdespont commented Dec 9, 2021

djhvscf commented Dec 12, 2021

sdespont commented Dec 20, 2021

djhvscf commented Dec 20, 2021

sdespont commented Dec 21, 2021

UtechtDustin commented Dec 21, 2021

sdespont commented Feb 8, 2022

wenzhixin commented Feb 9, 2022

djhvscf commented Feb 18, 2022

UtechtDustin commented Feb 18, 2022

djhvscf commented Feb 8, 2021 •

edited by UtechtDustin