fix missing unsplash.it background-image for .panel2 #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Yup seems like that image has been removed from the unsplash.it server for some reason. I think we can merge this PR or maybe use static images so that this kind of situation doesn't happen in future. What's your opinion on this @wesbos? |
Owner
|
thank you! Very helpful :) |
EmmDguez
pushed a commit
to EmmDguez/JavaScript30
that referenced
this pull request
Jun 10, 2018
fix missing unsplash.it background-image for .panel2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Wes!
Working my way through various lessons and noticed in this flex panels lesson that the image that was previously used for
.panel2's background-image is now missing. I've located what is hopefully a suitable replacement and changed it in the two HTML files.Here is the replacement image suggested in the commit:
https://source.unsplash.com/rFKUFzjPYiQ/1500x1500