fixing channel hang issues with large outbox tables #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 23, 2019 14:04
…to prevent streadway/amqp to deadlock
…cords from outbox
…fails When the extraction fails it prints out an error however this is due to the fact that the passed in message deaders do not contain the needed opentrace headers for extraction to work. This is expected as message producers do not necessarily pass in these headers so log level changed from error to debug in order not to litter the log
vladshub
approved these changes
Apr 24, 2019
| outbox.log().WithError(err).WithField("delivery_tag", ack).Error("failed to update delivery tag") | ||
| } | ||
| case nack := <-outbox.nack: | ||
| outbox.log().WithField("deliver_tag", nack).Info("nack received for delivery tag") |
Contributor
There was a problem hiding this comment.
You don't do Nack anymore?
Contributor
Author
There was a problem hiding this comment.
These nacks are the broker sending a negative confirm for the publication so we do not handle them and let the transactional outbox re publish the message the next time it scans for messages that were sent but not yet confirmed (that is done with the scavenging channel/goroutine)
| insert_date timestamp DEFAULT CURRENT_TIMESTAMP, | ||
| PRIMARY KEY(rec_id))` | ||
| PRIMARY KEY(rec_id), | ||
| INDEX status_delivery (rec_id, status, delivery_attempts))` |
Contributor
There was a problem hiding this comment.
If you change the order of the index to
Suggested change
| INDEX status_delivery (rec_id, status, delivery_attempts))` | |
| INDEX status_delivery (status, delivery_attempts, rec_id))` |
you would not need to git the USE INDEX (status_delivery) hint in the query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.