Skip to content

log only when messages were sent: #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2019
Merged

log only when messages were sent: #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01230de
log only when messages were sent:
May 5, 2019
da82ab3
fixed logging of resolved handlers
May 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion gbus/tx/mysql/txoutbox.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,9 @@ func (outbox *TxOutbox) sendMessages(recordSelector func(tx *sql.Tx) (*sql.Rows,
if err != nil {
outbox.log().WithError(err).Error("could not close Rows")
}
outbox.log().WithField("messages_sent", len(successfulDeliveries)).Info("outbox relayed messages")
if messagesSent := len(successfulDeliveries); messagesSent > 0 {
outbox.log().WithField("messages_sent", len(successfulDeliveries)).Info("outbox relayed messages")
}
for deliveryTag, id := range successfulDeliveries {
_, updateErr := tx.Exec("UPDATE "+getOutboxName(outbox.svcName)+" SET status=1, delivery_tag=?, relay_id=? WHERE rec_id=?", deliveryTag, outbox.ID, id)
if updateErr != nil {
Expand Down
3 changes: 2 additions & 1 deletion gbus/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,14 +179,15 @@ func (worker *worker) resolveHandlers(isRPCreply bool, bm *BusMessage, delivery
} else {
worker.handlersLock.Lock()
defer worker.handlersLock.Unlock()
worker.log().WithFields(log.Fields{"number_of_handlers": len(worker.registrations)}).Info("found message handlers")

for _, registration := range worker.registrations {
if registration.Matches(delivery.Exchange, delivery.RoutingKey, bm.PayloadFQN) {
handlers = append(handlers, registration.Handler)
}
}
}

worker.log().WithFields(log.Fields{"number_of_handlers": len(handlers)}).Info("found message handlers")
return handlers
}

Expand Down