Skip to content

Conversation

@nason
Copy link
Contributor

@nason nason commented Jan 10, 2017

Resolves #58

npm run benchmark:

> we-js-logger@0.5.1 benchmark /Users/mnason/code/we-js-logger
> node test/benchmark

we-js-logger x 334,953 ops/sec ±2.09% (83 runs sampled)
we-js-logger child x 154,756 ops/sec ±2.25% (78 runs sampled)
bunyan x 322,868 ops/sec ±1.49% (83 runs sampled)
bunyan child x 229,026 ops/sec ±1.62% (87 runs sampled)
Fastest is we-js-logger

I was kind of surprised by this result (I expected bunyan to be faster). It might be because we're not configuring we-js-logger to do anything extra in this benchmark.

Still, this could be helpful with issues such as #54 in the future.

Copy link
Contributor

@ricardo-quinones ricardo-quinones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.174% when pulling bab02dc on benchmark into fc7b5bd on master.

@mattjstar
Copy link
Contributor

mattjstar commented Jan 10, 2017

Huh, that seems bizarre that we-js-logger would be faster, but it seems like the child is significantly slower or am I reading that incorrectly?

@nason
Copy link
Contributor Author

nason commented Jan 10, 2017

Huh, that seems bizarre that we-js-logger would be faster, but it seems like the child is significantly slower or am I reading that incorrectly?

That's what I see too. Its not what I expected but at least we have some visibility into it now!

@nason nason merged commit e9615ee into master Jan 10, 2017
@nason nason deleted the benchmark branch January 10, 2017 21:10
@mattjstar
Copy link
Contributor

haha sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants