Pass name to logentries client and only init once #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nason
commented
Jan 24, 2017
| export default function ClientLogentriesLogger({ name, token }) { | ||
| try { | ||
| // If a LE logger does not exist with this name, this will throw | ||
| LE.to(name); |
Contributor
Author
There was a problem hiding this comment.
This goes down this path: https://github.com/rapid7/le_js/blob/master/src/le.js#L342
The issue we're seeing comes from the init call being made for every logger instance (including children) when a logentries token is present. This was introduced by the refactor in #68
i8ramin
approved these changes
Jan 24, 2017
Contributor
i8ramin
left a comment
i8ramin
left a comment
There was a problem hiding this comment.
Not sure I fully understand the nature of this change, but I trust ya.
Contributor
Author
|
@i8ramin we're seeing this error when we have logentries configured:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.