Skip to content

Conversation

@nason
Copy link
Contributor

@nason nason commented Feb 9, 2017

A few of our apps using this library get some traffic from IE <= 9. In those browsers, console is undefined unless the developer tools have been opened. Otherwise, an exception is thrown when a console method is invoked.

This passes our use of console through the console lib, which will stub out console methods for us in this situation https://github.com/matthewhudson/console/blob/master/console.js

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.221% when pulling cbe313a on safe-console into d62d946 on master.

@nason nason merged commit 9e3a12d into master Feb 9, 2017
@nason nason deleted the safe-console branch February 9, 2017 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants