Fix Mapbox raster marker colors and night visibility #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phpduy
requested review from
QuocNguyen-w3w,
linhha2000,
mani-apps and
nghianguyen-w3w
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously used
rasterContrastas a shortcut to implement the marker background color in night mode (it actually coincidentally worked for some colors). The proper solution is to userasterEmissiveStrength. For more information, you can read here: https://docs.mapbox.com/map-styles/standard/guides/#emissive-strength--custom-layersThe video below also shows the current progress of the refactor in the core app 😉
Screen_recording_20251120_050353.webm