Refactor CameraState update mechanism #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phpduy
commented
Dec 5, 2024
phpduy
commented
- Ensures the internal W3WCameraState updates continuously to reflect changes in the GoogleMap or MapBox camera state.
- Relocates the debounce mechanism for grid line calculations to W3WMapManager, centralizing the logic for better control and consistency.
- Refactors W3WMapManager to improve readability and maintainability by breaking down large functions into smaller functions.
kaytran2992
approved these changes
Dec 6, 2024
QuocNguyen-w3w
approved these changes
Dec 6, 2024
phpduy
merged commit a93f18d
into
epic/MT-6865-Create-a-new-UI-for-Map-component
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.