Skip to content

Fix <dfn> of -webkit-flex #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2020
Merged

Fix <dfn> of -webkit-flex #134

merged 2 commits into from
Dec 16, 2020

Conversation

@gsnedders
Copy link
Member

@gsnedders gsnedders commented Oct 10, 2020 •
edited by pr-preview bot
Loading

This maintains the id it had, but fixes the link text to be the expected name of the property

[editorial]

Preview | Diff

@saschanaz
Copy link
Member

saschanaz commented Dec 16, 2020

Could you also do this for -webkit-flex-valdef?

@gsnedders
Fix <dfn> of -webkit-flex property
2afe4b8 
This maintains the id it had, but fixes the link text to be the expected
name of the property
@gsnedders
Fix <dfn> of -webkit-flex keyword
0505050 
This maintains the id it had, but fixes the link text to be the expected
name of the keyword
@gsnedders
Copy link
Member Author

gsnedders commented Dec 16, 2020

Could you also do this for -webkit-flex-valdef?

Done!

domenic
domenic approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@domenic domenic merged commit ab0693a into whatwg:master Dec 16, 2020
@gsnedders gsnedders deleted the patch-1 branch December 16, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domenic domenic domenic approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gsnedders @saschanaz @domenic