Skip to content

console.assert improvements #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

console.assert improvements #41

wants to merge 2 commits into from

Conversation

@robertkowalski
Copy link
Member

@robertkowalski robertkowalski commented Jan 28, 2016

  • Adds found differences for Chrome & Firefox.
  • Fixes method signature to support multiple arguments and not just one message.

As the logger function is called if the assertion fails, console.assert MUST support format specifiers, which closes #4

@terinjokes
Copy link
Collaborator

terinjokes commented Jan 29, 2016

LGTM 👍

@domenic
Copy link
Member

domenic commented Jan 30, 2016

LGTM, maybe add "closes #4" to the second commit.

@robertkowalski
document differences for console.assert formatting
657b2bb
@robertkowalski
console.assert: support format specifier
dd52f49 
support multiple arguments and not just one message. as the logger
is called if the assertion fails, console.assert MUST support
format specifiers.
robertkowalski added a commit that referenced this pull request Jan 30, 2016
@robertkowalski
document differences for console.assert formatting
55d6b27 
PR: #41
PR-URL: #41
Reviewed-By: Terin Stock <terin@terinstock.com>
Reviewed-By: Domenic Denicola <d@domenic.me>
robertkowalski added a commit that referenced this pull request Jan 30, 2016
@robertkowalski
console.assert: support format specifier
6ec9f98 
support multiple arguments and not just one message. as the logger
is called if the assertion fails, console.assert MUST support
format specifiers.

PR: #41
PR-URL: #41
Reviewed-By: Terin Stock <terin@terinstock.com>
Reviewed-By: Domenic Denicola <d@domenic.me>
@robertkowalski
Copy link
Member Author

robertkowalski commented Jan 30, 2016

merged with the edge addition - but i forgot the fixes comment :(

@robertkowalski robertkowalski deleted the console-assert branch January 30, 2016 21:53
@robertkowalski robertkowalski mentioned this pull request Jan 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

allow formatting specifiers in console.assert.

4 participants

@robertkowalski @terinjokes @domenic