-
Notifications
You must be signed in to change notification settings - Fork 318
Allow the creation of null registry element and shadow root #1424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@rniwa @annevk here's another PR from what we discussed. May be a dumb question: with this change, we probably no longer want to use null as the default vaule for |
|
You mean someone doing: |
|
This matches my understanding of the first set of changes proposed in #1413 (comment) and agreed to at TPAC. Good job! |
…ing null to createEleent and attachShadow per whatwg/dom#1424 Also update the existing tests to account for the behavior differences.`
…ing null to createEleent and attachShadow per - whatwg/dom#1424 - whatwg/dom#1423 Also update the existing tests to account for the behavior differences.`
annevk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo (my) nits.
…ing null to createEleent and attachShadow per - whatwg/dom#1424 - whatwg/dom#1423 Also update the existing tests to account for the behavior differences.`
…ing null to createEleent and attachShadow per (#56108) - whatwg/dom#1424 - whatwg/dom#1423 Also update the existing tests to account for the behavior differences.`
As part of the effort to support null custom element registry elements without shadow DOM, we're updating the spec to allow the creation of element and shadowroot to use null as a valid argument and create null registry element and shadowroot.
Fixes #1413 partially. We need another PR to support element attribute for null custom element registry in addition to #1423.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff