Skip to content

Escape markup characters properly in XHTML DTD #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2015
Merged

Escape markup characters properly in XHTML DTD #39

merged 1 commit into from
Nov 9, 2015

Conversation

@abacabadabacaba
Copy link
Contributor

@abacabadabacaba abacabadabacaba commented Nov 9, 2015

A fix for whatwg/html#317

@zcorpan
Copy link
Member

zcorpan commented Nov 9, 2015

I tried running ./build.sh with this change but it did not change the "the URL given by this link" DTD in the spec, as far as I can tell.

@abacabadabacaba
Copy link
Contributor Author

abacabadabacaba commented Nov 9, 2015

Try to delete .cache directory (or just .cache/entities.inc) and rerun ./build.sh.

@annevk
Copy link
Member

annevk commented Nov 9, 2015

As far as I can tell this works, I get <!ENTITY AMP "&#x26;#x26;"> etc.

@annevk annevk merged commit 6a775cd into whatwg:master Nov 9, 2015
@annevk
Copy link
Member

annevk commented Nov 9, 2015

Thank you @abacabadabacaba!

@abacabadabacaba abacabadabacaba deleted the patch-1 branch November 9, 2015 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abacabadabacaba @zcorpan @annevk