Fix dialog focus restoring descendant check #10994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Member
It would be good to ensure this is tested; could you link to tests which would fail if we did not implement the spec correctly? |
@domenic Those two WPT subtests would fail, given current spec: |
In whatwg#9178 I accidentally made the currently focused element check look for the element to restore focus on as an ancestor instead of the dialog element "subject". This PR corrects this to look at the dialog element instead of the element to restore focus to. This was identified here: whatwg#9178 (comment)
domenic
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9178 I accidentally made the currently focused element check look for the element to restore focus on as an ancestor instead of the dialog element "subject". This PR corrects this to look at the dialog element instead of the element to restore focus to.
This was identified here: #9178 (comment)
Not sure what to do with the checklist these days for a minor bug fix on already approved/agreed upon behavior.
(See WHATWG Working Mode: Changes for more details.)
/interactive-elements.html ( diff )