Fix OffscreenCanvas's convertToBlob()'s copypasta #11106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And modernize its description while here. Fixes #11101.
domenic
approved these changes
Mar 7, 2025
| data-x="offscreencanvas-context-mode">context mode</span> is <span | ||
| data-x="offscreencanvas-context-2d">2d</span> and the rendering context's <span>output | ||
| <li><p>If <span>this</span>'s <span data-x="offscreencanvas-context-mode">context mode</span> is | ||
| <span data-x="offscreencanvas-context-2d">2d</span> and the rendering context's <span>output |
There was a problem hiding this comment.
I wish I could figure out how to get to "output bitmap" (i.e. a better version of "the rendering context"), but there's nothing obvious, so probably best to leave it as-is for now.
There was a problem hiding this comment.
Yeah, it's wild that rendering context is not an explicit concept member to this day.
source
Outdated
|
|
||
| <li><p>Let <var>result</var> be a new promise object.</p></li> | ||
|
|
||
| <li><p>Let <var>offscreenCanvas</var> be <span>this</span>.</p></li> |
There was a problem hiding this comment.
I think it's OK to close over "this" in in-parallel steps. (At least, I've done so a number of times.)
There was a problem hiding this comment.
Interesting. I can make this change. I also filed #11110.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And modernize its description while here.
Fixes #11101.
/canvas.html ( diff )