Fix document access in shared history push/replace steps #11204
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #11199. As discussed there, there are deeper issues around whether a History object is associated with a Window vs. History object, and how that intersects with #3267 around Window object reuse. However, in the meantime, this makes the traversal from History → Document consistent with the rest of the specification, and stops using the undefined concept of "history's associated Document".
annevk
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11199.
As discussed there, there are deeper issues around whether a History object is associated with a Window vs. History object, and how that intersects with #3267 around Window object reuse.
However, in the meantime, this makes the traversal from History → Document consistent with the rest of the specification, and stops using the undefined concept of "history's associated Document".
/nav-history-apis.html ( diff )