Remove incorrect usages of link options destination #11757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The destination field in link options is initialized to the empty string and can no longer be nullable. Therefore the null check is no longer valid, since the destination is always set to a non-null value. Secondly, we already initialize to the empty string and therefore don't need to reassign the value to the empty string during prefetch loading.
noamr
reviewed
Oct 6, 2025
noamr
approved these changes
Oct 6, 2025
Collaborator
noamr
left a comment
noamr
left a comment
There was a problem hiding this comment.
LGTM, thanks for working on this.
Contributor
Author
|
@annevk can you help me figure out what else I need to do to land this? Not sure who I should reach out to for approvals. |
Member
|
Thanks Tim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The destination field in link options is initialized to the empty string
and can no longer be nullable. Therefore the null check is no longer
valid, since the destination is always set to a non-null value. Secondly,
we already initialize to the empty string and therefore don't need
to reassign the value to the empty string during prefetch loading.
(This is a follow-up to #11727 and as such doesn't use the template either.)
/links.html ( diff )
/semantics.html ( diff )