Fix form submission's encoding algorithms #1330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the following things: * Makes algorithms other than multipart/form-data return code points rather than bytes, since most callers want code points. With this change we are no longer required to use US-ASCII and more importantly it removes a redundant encode/decode roundtrip. * No longer use multipart/form-data for “Mail as body” since that does not match implementations. They only support the other two encodings there. “Submit as entity body” is the only algorithm that supports multipart/form-data (which makes sense, since a MIME type is required to interpret it). Fixes #663.
| to the <var>submitter</var> element's <span>node document</span>. If this fails, abort these | ||
| steps.</p></li> | ||
|
|
||
| <li><p>Let <var>action</var> be the <span>resulting URL string</span>.</p></li> |
Member
There was a problem hiding this comment.
Was this just an unused variable?
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the following things:
rather than bytes, since most callers want code points. With this
change we are no longer required to use US-ASCII and more importantly
it removes a redundant encode/decode roundtrip.
not match implementations. They only support the other two encodings
there. “Submit as entity body” is the only algorithm that supports
multipart/form-data (which makes sense, since a MIME type is required
to interpret it).
Fixes #663.