Skip to content

Conversation

@annevk
Copy link
Member

@annevk annevk commented Sep 23, 2015

See whatwg/url#62 for details.

source Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, the en-GB-x-hixie vs. en-US is screwing us here. Are you sure you want (some of) the data-x's to use z, matching URL, whereas the human text uses s?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|'m not. I guess once we use data-x-href more consistently the internal data-x value is really irrelevant. We could also move back to US and perhaps no longer declare -hixie since he's no longer the sole editor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, maybe a good long term plan. In the meantime maybe just stay consistent? Not a blocker for this PR though IMO.

@annevk
Copy link
Member Author

annevk commented Sep 24, 2015

There's actually a small theoretical problem that I wonder if anyone has input on. When WorkerGlobalScope is created its url is null. It only becomes non-null after the worker script has been fetched. We could also make it the constructor url until fetching has happened I suppose but that seems even more of a lie. However, that means that until that time workerGlobalScope.location is in a somewhat fragile state. Now this cannot be observed on the web so it is not technically a problem, but it does seem unclean.

@domenic
Copy link
Member

domenic commented Sep 24, 2015

I really am not worried about that personally, since you can't run script that accesses location until script is loaded, so the intermediate state is not observable.

If you make the change to having a WorkerGlobalScope, then maybe I'd think of inserting a note like "This WorkerLocation's associated WorkerGlobalScope will only have its url property set after the worker script has been fetched. This does not impact the above algorithms, since these getters can only run after script has been fetched."

@annevk annevk assigned domenic and unassigned annevk Sep 24, 2015
@annevk
Copy link
Member Author

annevk commented Sep 24, 2015

My main worry now is that while WorkerLocation objects are created, WorkerNavigator objects (and maybe others?) are not. However, we can fix them as we go I suppose. I would appreciate another quick look.

@annevk annevk mentioned this pull request Sep 24, 2015
11 tasks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/the/this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not doing this given the definition of self. Once IDL defines this life will get better.

@domenic
Copy link
Member

domenic commented Sep 25, 2015

Commit message title is too long by GitHub's standards

@domenic
Copy link
Member

domenic commented Sep 25, 2015

LGTM with nits

The URLUtils abstraction is not working out. See #164 and whatwg/url#62 for details.
@annevk annevk merged commit 32a7a20 into master Sep 25, 2015
@annevk annevk deleted the urlutilsreadonly branch September 25, 2015 08:48
nathaneliason pushed a commit to nathaneliason/html that referenced this pull request Jun 16, 2022
This fixes whatwg#187 by hard-coding knowledge of the post-syntax-highlighting markup into the script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants