-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add images to embedded content introduction's examples #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The SVGs are not DRY, but the shapes are really simple, and it seems good to have them be self-contained. Though I suppose they could use The SVGs have no accessibility stuff yet. They are all redundant with the text above them, technically, but I'm not sure if they should have |
c49d744 to
7396657
Compare
Went with |
2258e21 to
e3b8318
Compare
e3b8318 to
ff1e245
Compare
|
@doomdavve Thanks, fixed. |
ff1e245 to
2ca3d53
Compare
|
@zcorpan I got the properties mixed up in a previous round: dominant-baseline=middle is probably close to what you need in this context, alignment-baseline is for children like tspan aligning with a text parent. (Seems to be interoperability issues hiding here...) Thanks for the patience! |
|
Now I see http://stackoverflow.com/questions/12250403/vertical-alignment-of-text-element-in-svg has a note about IE not supporting dominant-baseline. |
|
And no further comments. Seems like a great improvement! (It itches a little to draw the tablet as a single path and get consistent inner rounding and no gaps as I get in Blink based browsers, but illustration-wise I think it's fine as it is). |
* Images illustrating screen size, pixel density, orientation, viewport-based selection, and art direction. * New raster images are public domain, attributed in acks. * Change the president example to a wolf to reuse that image. * Rewrap.
2ca3d53 to
14111f6
Compare
|
Thanks! I changed to |
viewport-based selection, and art direction.