Make the default "process the linked resource" algorithm a noop #6156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the requirement for <link rel="icon"> to fire load and error events, which no implementation followed. Closes whatwg#6122.
domenic
requested changes
Nov 18, 2020
source
Outdated
| <li><p>Otherwise, <span data-x="concept-event-fire">fire an event</span> named <code | ||
| data-x="event-error">error</code> at <var>el</var>.</p></li> | ||
| </ol> | ||
| algorithm, the <dfn>default process the linked resource</dfn> algorithm does nothing.</p> |
Member
There was a problem hiding this comment.
I don't think the <dfn> is necessary anymore. Instead, let's copy the verbiage from above, where it says
Similarly, individual link types may provide their own linked resource fetch setup steps, but unless explicitly stated, these steps just return true.
domenic
approved these changes
Nov 18, 2020
Member
|
Forgot to say, thanks very much for tracking this down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the requirement for
<link rel="icon">to fireloadanderrorevents, which no implementation followed.Closes #6122.
(See WHATWG Working Mode: Changes for more details.)
/semantics.html ( diff )