Export "listener" and "event handler map". #9021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jakearchibald As you have requested, I have written the PR. |
Collaborator
|
@domenic I'm happy for this to land with the wrapping change. |
domenic
reviewed
Mar 15, 2023
Contributor
Author
|
I think I have addressed all the comments. |
domenic
approved these changes
Mar 17, 2023
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
Apologies for the delay. Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These definitions will be used by the service worker specification I am working on now in w3c/ServiceWorker#1672.
The reviewer requested me to export definitions before they are used in the service worker specification.
/webappapis.html ( diff )