Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception if model metrics are incomplete #456

Closed
wants to merge 913 commits into from

Conversation

cswarth
Copy link
Contributor

@cswarth cswarth commented Feb 25, 2022

Description

Throw exceptions if validation errors are detected when decoding model metrics protobuf messages.
Previously these were generating log messages that were easily overlooked in batch processing situations.

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

valer-whylabs and others added 30 commits May 11, 2021 18:06
* move viewer to within whylogs

* add profile viewer

* 📚 add documentation for viewer

* edits on profile viewer documentation

* remove dividers

* typos,and loom gif

* use thumbnail gif from loom

* Update README.md

Co-authored-by: Andy Dang <26821974+andyndang@users.noreply.github.com>

* move metric collection list

* Remove dots

* Updating whylogs demo gif

* Update README.md

* Update README.md

* Update README.md

* bump version 0.4.8

Co-authored-by: Andy Dang <26821974+andyndang@users.noreply.github.com>
Co-authored-by: Sam Gracie <4944259+samgracie@users.noreply.github.com>
…cker. (#234)

For existing profiles, we can workaround by adding the two values together.
For new profiles after this PR, the `null_count` will always come from SchemaTracker and not Counters

Addressing #232
)

* add character position tracker

* add string attributes to  flat summary

* track unicode characters as NITL

* add string notebook
Co-authored-by: Chris Warth <csw@whylabs.ai>
Co-authored-by: Andy Dang🤖 <andy@whylabs.ai>
github-actions bot and others added 8 commits February 17, 2022 10:36
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Don't include secrets
* Fix KS test p-value computation, add condition in entropy

* Change number of samples calculation

Co-authored-by: Jamie Broomall <88007022+jamie256@users.noreply.github.com>
* Fix typos and add example for the missing values proportion constraint in Constraints_Suite

Co-authored-by: pecop2 <petar@loka.com>
Co-authored-by: MilenaTrajanoska <trajanoska28@gmail.com>
Co-authored-by: Jamie Broomall <88007022+jamie256@users.noreply.github.com>
…sages (#450)

* Add total executions and failures in ValueConstraintMsg

* Edit from_protobuf to use the total executions and failures

addresses #445

Co-authored-by: pecop2 <petar@loka.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@cswarth cswarth added the enhancement New feature or request label Feb 25, 2022
@cswarth cswarth changed the title throw exception if model metrics are incomplete Throw exception if model metrics are incomplete Feb 25, 2022
@coveralls
Copy link

coveralls commented Feb 25, 2022

Pull Request Test Coverage Report for Build 1897004716

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4513 of 5202 (86.76%) changed or added relevant lines in 68 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.526%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/whylogs/cli/init.py 43 44 97.73%
src/whylogs/core/model_profile.py 36 37 97.3%
src/whylogs/core/statistics/counterstracker.py 24 25 96.0%
src/whylogs/core/statistics/datatypes/variancetracker.py 46 47 97.87%
src/whylogs/core/statistics/numbertracker.py 91 92 98.91%
src/whylogs/logs/init.py 20 21 95.24%
src/whylogs/util/stats.py 12 13 92.31%
src/whylogs/util/time.py 9 10 90.0%
src/whylogs/viz/base.py 27 28 96.43%
src/whylogs/core/columnprofile.py 125 127 98.43%
Totals Coverage Status
Change from base Build 1888783176: 0.0%
Covered Lines: 4767
Relevant Lines: 5626

💛 - Coveralls

@cswarth cswarth marked this pull request as draft February 25, 2022 20:02
FelipeAdachi and others added 15 commits February 28, 2022 20:41
* Add feast integration demo

* - Removed parquet files from the repo and moved to s3

* add .gitkeep to push empty data folder
Added logo, cleaned up intro text, reorganized some sections
Cleaned up typos, added Contributors subsection, centered badges, added a section describing what can be done with profiles
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jamie Broomall <88007022+jamie256@users.noreply.github.com>
* Fix missing dataTimestamp post aggregation
* Add a scala test to cover deserializing the dataTimestamp from the DatasetProfile
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* add performance metrics  - classification and regression - notebooks
* Matrix build for Spark and Scala versions
* add spark 3.1.1
* publish matrix builds
* include Spark 3.2 & Scala 2.13
* need os in included matrix entry
* Scala 2.13 will need code changes
* match publish matrix to build matrix
* spark/scala default versions

Co-authored-by: Richard Rogers <rrogers@opendius.net>
Co-authored-by: Jamie Broomall <88007022+jamie256@users.noreply.github.com>
* visualizer new design, add reference profile in profile viewer
* add json reference profile button, add UI changes
* change view detail button position, change referenceProfilePanel chart view, add icons
* add property panel for reference profile, charts for json profile without reference
* add the notification sign of filter button
* use addFileName() function when the file is load
* add "Filter by type" design changes, add "Quick search" design changes.
* add "Quick search" input.
* count of types in "filter by type" dropdown
* add double histogram chart in reference profile panel.
* "Sign up for a free WhyLabs account" button disappears when screen with less than 1000px.
* add reference profile charts, add profile name and time stamp
* add diff from ref when reference profile consists.
* Shows alert when the key of profile data is not matched to reference profile data.
* histograms visualization in jupyter notebook
* add backend for jupyter notebook vizualisation, add jupyter notebook to display profile data in the notebook
* add double histogram visualization
* responsive distribution chart
* add search logic
* add folder for saved htmls, add all methods to jupyter notebook cells, change backend code stucture
* add frequent items in reference property panel
* add feature summary statistics backend, add single profile summary statistics backend
* add Full Profile Summary Statistics visualization
* add Feature Summary Statistics visualisation
* add ability to add multiple features in double histogram.
* show full number at hover on statistics numbers
* add documentation in notebook, naming fixes
* add calculations in backend for variance and coefficient of variation
* add constraints report backend, add constraints report in notebook
* constraints report with real values
* Categorical drift report: Differenced Bar chart jupyter visualization
* Add definition (ranges) for the severe, moderate, low drift categories.
* change import in tests, add categorical profile generator in tests
* change css and js paths for browser visualizer
* Histogram Bin Width and Range (#468)
- Changed upper value of domain's xscale to match the max between both distribution's -> max of bin value + bin_width
- apply Xscale to each of distribution's [1] and [0] before calculating bar width, instead of scaling the difference ([1]-[0])

Co-authored-by: Perch <perchgithub@gmail.com>
Co-authored-by: ssxcho <xchton@gmail.com>
Co-authored-by: Jamie Broomall <88007022+jamie256@users.noreply.github.com>
Co-authored-by: Khachatur Tonoyan <31924981+ssxcho@users.noreply.github.com>
Co-authored-by: Perch2005 <78492631+Perch2005@users.noreply.github.com>
Co-authored-by: Felipe Adachi <felipeadachi@gmail.com>
)

Co-authored-by: Jamie Broomall <88007022+jamie256@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet