Skip to content

Add merge clause for huwiki#153

Merged
halfak merged 1 commit intomasterfrom
huwiki_merge
Apr 13, 2018
Merged

Add merge clause for huwiki#153
halfak merged 1 commit intomasterfrom
huwiki_merge

Conversation

@adamwight
Copy link
Contributor

This patch adds rules to merge human- and auto-labeled data.

It's interesting what must have happened on the master branch: we had no rules for the labeled_revisions files, so I imagine that model training used stale data left in the directory from previous runs. Our makefile generator should make this impossible, by asserting that exactly one method of producing the labeled-revisions files is present.

@adamwight
Copy link
Contributor Author

n.b., I'm building the models, but this PR can be merged separately from the binaries.

@codecov
Copy link

codecov bot commented Apr 12, 2018

Codecov Report

Merging #153 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   20.93%   20.93%           
=======================================
  Files          58       58           
  Lines        1070     1070           
=======================================
  Hits          224      224           
  Misses        846      846

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af81a23...b4f3988. Read the comment docs.

@halfak halfak merged commit 657b7fb into master Apr 13, 2018
@halfak halfak deleted the huwiki_merge branch April 13, 2018 13:57
Ladsgroup pushed a commit that referenced this pull request Aug 20, 2018
 
Merge pull request #153 from wiki-ai/huwiki_merge

Add merge clause for huwiki
Ladsgroup pushed a commit that referenced this pull request Dec 17, 2018
 
Merge pull request #153 from wiki-ai/huwiki_merge
Add merge clause for huwiki
Ladsgroup pushed a commit that referenced this pull request Jan 21, 2019
 
Merge pull request #153 from wiki-ai/huwiki_merge
Add merge clause for huwiki
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants