Merged
Conversation
Contributor
Author
|
n.b., I'm building the models, but this PR can be merged separately from the binaries. |
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 20.93% 20.93%
=======================================
Files 58 58
Lines 1070 1070
=======================================
Hits 224 224
Misses 846 846Continue to review full report at Codecov.
|
Ladsgroup
pushed a commit
that referenced
this pull request
Aug 20, 2018
Ladsgroup
pushed a commit
that referenced
this pull request
Dec 17, 2018
Ladsgroup
pushed a commit
that referenced
this pull request
Jan 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds rules to merge human- and auto-labeled data.
It's interesting what must have happened on the master branch: we had no rules for the
labeled_revisionsfiles, so I imagine that model training used stale data left in the directory from previous runs. Our makefile generator should make this impossible, by asserting that exactly one method of producing the labeled-revisions files is present.