-
Notifications
You must be signed in to change notification settings - Fork 0
Add comments #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add comments #1
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,6 +88,8 @@ def test_string | |
| with_test_routes do | ||
| # FIXME: why are these different? Symbol case passes through to | ||
| # `polymorphic_url`, but the String case doesn't. | ||
| # これ単純に消しても問題ないコメントなのかも? | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✋ |
||
| # [test for inconsistency between String and Symbol url_for handling · rails/rails@37d4415](https://github.com/rails/rails/commit/37d4415a7b433fcb987b1c6a5b51bf2d8efc5d5e) | ||
| assert_equal "http://example.com/projects", polymorphic_url("projects") | ||
| assert_equal "projects", url_for("projects") | ||
| end | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -498,6 +498,7 @@ def test_second_to_last | |
|
|
||
| #test with limit | ||
| # assert_equal nil, Topic.limit(1).second # TODO: currently failing | ||
| # 今日の master コンソール上で試したら nil 帰ってきたのでもう動くのではという気がする | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. これ嘘でした><2番目のレコード返ってきちゃいますね… |
||
| assert_equal nil, Topic.limit(1).second_to_last | ||
| end | ||
|
|
||
|
|
@@ -527,8 +528,10 @@ def test_third_to_last | |
|
|
||
| # test with limit | ||
| # assert_equal nil, Topic.limit(1).third # TODO: currently failing | ||
| # 今日の master コンソール上で試したら nil 帰ってきたのでもう動くのではという気がする | ||
| assert_equal nil, Topic.limit(1).third_to_last | ||
| # assert_equal nil, Topic.limit(2).third # TODO: currently failing | ||
| # 今日の master コンソール上で試したら nil 帰ってきたのでもう動くのではという気がする | ||
| assert_equal nil, Topic.limit(2).third_to_last | ||
| end | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ | |
| require 'support/connection' | ||
|
|
||
| # TODO: Move all these random hacks into the ARTest namespace and into the support/ dir | ||
|
|
||
| # ロジック移動させるだけで済むのかもしれない | ||
| Thread.abort_on_exception = true | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✋ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @willnet これ見てるんですが、移動するっていうのは、単に There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @takayukishmz "these random hacks" がどこまで指すのかはわからないです(全部だとつらいですね><)。 内容てきにはsupport/config.rb support/connection.rb などに ARTest module が定義されているので、ARTest のメソッドとして定義して実行したいってことなのかなと思いました。 例えばこんな感じ |
||
|
|
||
| # Show backtraces for deprecated behavior for quicker cleanup. | ||
|
|
@@ -202,3 +202,5 @@ def in_time_zone(zone) | |
| end | ||
|
|
||
| require 'mocha/setup' # FIXME: stop using mocha | ||
| # 根気があれば直せるのでは | ||
| # ひたすら minitest のモックの記法に置換していくだけでいける? | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. この行削ったら落ちたテストの数
多分重複してるのもあるけどなかなか厳しい数字 |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,6 +45,8 @@ def replied_topic | |
| # TODO Add :on case, but below doesn't work, because then the validation isn't run for some reason | ||
| # even when using .save instead .valid? | ||
| # [ "given on condition", {on: :save}, {}] | ||
| # とりあえず、ある程度泥臭く書けば on はサポートできそう | ||
| # そこから綺麗に書ける方法を見つけられればマージされるのでは? | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. これ俺やってみます。 |
||
| ] | ||
|
|
||
| COMMON_CASES.each do |name, validation_options, generate_message_options| | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✋