-
Notifications
You must be signed in to change notification settings - Fork 2
Upgrade to Yarn Modern #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to fix the "focus" behavior of Yarn workspace. In Yarn 1.x, a focused install of a workspace will fail when other workspaces are private.
Do not install or build the demo workspace. The dependencies of that workspace do not need the same Node version support as the npm package.
This allows for linting a single focused workspace instead of all workspaces. Isolate project-specific ESLint configs in their respective config files.
Convert "format" into a global script that can be run from any project.
796d443 to
0dd32d5
Compare
"yarn workspaces focus" may be unnecessary after upgrading to Yarn Modern.
The workaround for #66 seems to be no longer necessary.
Fix error in GitHub Actions: The lockfile would have been created by this install, which is explicitly forbidden.
ts=jest has a peer dependency on jest-util, which is a dependency of jest. But evidently Yarn Modern requires a more explicit dependency on jest-util.
# Conflicts: # packages/regex-to-strings/package.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #229 +/- ##
========================================
Coverage 99.29% 99.29%
========================================
Files 22 22
Lines 424 424
Branches 67 69 +2
========================================
Hits 421 421
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade package manager from Yarn Classic (1.x) to Yarn Modern.
Use per-project lint configuration files.
Require testpack to succeed for all Node versions.