Skip to content

Check Prettier formatting in CI pipeline #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2021
Merged

Check Prettier formatting in CI pipeline #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
442519a
Check Prettier formatting in CI pipeline
wimpyprogrammer Dec 12, 2021
2e57420
Check Prettier formatting before TypeScript compile
wimpyprogrammer Dec 12, 2021
3096635
Reformat demo page with Prettier
wimpyprogrammer Dec 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
node-version: ${{ matrix.node-version }}

- run: npm install
- run: npx prettier --check .
- run: npm run lint
- run: npm run build
- run: npm run test
Expand Down
16 changes: 5 additions & 11 deletions demo/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

<!-- Google Tag Manager -->
<script>
(function(w, d, s, l, i) {
(function (w, d, s, l, i) {
w[l] = w[l] || [];
w[l].push({
'gtm.start': new Date().getTime(),
Expand Down Expand Up @@ -54,17 +54,15 @@
src="https://www.googletagmanager.com/ns.html?id=GTM-M4R3GP7"
height="0"
width="0"
style="display:none;visibility:hidden"
style="display: none; visibility: hidden"
>
</iframe>
</noscript>
<!-- End Google Tag Manager (noscript) -->

<nav class="navbar navbar-expand-lg navbar-dark bg-primary">
<div class="container">
<a class="navbar-brand" href="javascript:void(0)">
RegEx to Strings
</a>
<a class="navbar-brand" href="javascript:void(0)"> RegEx to Strings </a>
<a
href="https://github.com/wimpyprogrammer/regex-to-strings"
title="See regex-to-strings on GitHub"
Expand Down Expand Up @@ -118,9 +116,7 @@

<div class="form-inline">
<div class="form-group">
<label for="delimiter">
Separate results by:
</label>
<label for="delimiter"> Separate results by: </label>
<select
id="delimiter"
class="form-control js-delimiter track-field"
Expand All @@ -133,9 +129,7 @@
</div>

<div class="form-group">
<label for="max-results">
Maximum number of results:
</label>
<label for="max-results"> Maximum number of results: </label>
<input
class="form-control js-max-results track-field"
id="max-results"
Expand Down
3 changes: 0 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
"build:demo": "wp --config demo/webpack.config.js",
"format": "prettier --write '{src,demo/src}/**'",
"lint": "tsc -b ./tsconfig.lint.json && eslint . --report-unused-disable-directives",
"precommit": "pretty-quick --staged",
"release": "npx release-it",
"test": "jest --coverage"
},
Expand All @@ -54,13 +53,11 @@
"eslint-import-resolver-typescript": "^2.4.0",
"eslint-plugin-import": "^2.25.3",
"eslint-plugin-jest": "^25.2.1",
"husky": "7.0.4",
"jest": "^27.0.1",
"jest-when": "^3.2.1",
"node-sass": "^7.0.0",
"npm-run-all": "^4.1.5",
"prettier": "2.2.1",
"pretty-quick": "3.1.2",
"sass-loader": "^12.0.0",
"style-loader": "^3.0.0",
"ts-jest": "^27.0.1",
Expand Down