feat: improved dedicated benchmarks + buffer fix #2313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
0fa0f09
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cc5ef507.windmill.pages.dev |
| Branch Preview URL: | https://fix-benchmarks-completed-job.windmill.pages.dev |
rubenfiszel
reviewed
Sep 20, 2023
| #[cfg(feature = "benchmark")] | ||
| let main_duration = main_duration2.clone(); | ||
|
|
||
| tokio::spawn(async move { |
Contributor
There was a problem hiding this comment.
we should spawn only if dedicated_worker is set (which can be a static boolean set in a parent) or the job kind is Noop. Otherwise do directly inside while body
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.