Simple download #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would have preferred io.Reader, but s3.PutObjectInput ugh Smaller interfaces allows the function to be used by more types
So we have to find another way to introduce paths
choonkeat
commented
Dec 19, 2017
| http.Error(w, fullpath, http.StatusNotFound) | ||
| return | ||
| } | ||
| io.Copy(w, stream) |
Collaborator
Author
There was a problem hiding this comment.
NOTE that we didn't set Content-Type response header yet
- We can sniff again and set the
Content-Type(oh noes, gotta read 512 bytes and juggle rewinding theio.Reader...) - OR better, when we store the file into backend (e.g. s3, google cloud storage, ...) we should've put the sniffed content type as metadata (e.g. see PutObjectInput.Metadata. So that when we perform download, we can resupply the
Content-Typewithout re-sniffing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http.ResponseWriter(no processing)unfortunately, some lambda platforms (e.g. google cloud) gives very specific url
i.e.
will hit your lambda function, but
will NOT hit your lambda function; returns 404
so in order for us to retrieve images like
we'd need to specify instead as,
and do some
strings.TrimPrefix(r.URL.RequestURI(), "/attache?")to obtain the"resize/100x/987654321.gif"