Skip to content

Conversation

@randomguy-2650
Copy link
Contributor

@randomguy-2650 randomguy-2650 commented Oct 5, 2025

Description (required)

This PR fixes the brand name capitalisation of npm in https://docs.astro.build/en/reference/publish-to-npm.

Note

Despite adding i18nIgnore in the title, it might need to be updated in all the other languages that have this page (that at least aren’t outdated).

npm capitalisation source: https://github.com/npm/cli?tab=readme-ov-file#is-it-npm-or-npm-or-npm

Related issues & labels (optional)

  • Suggested label: i18n, hacktoberfest-accepted

Hacktoberfest 🎃

@netlify
Copy link

netlify bot commented Oct 5, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2a2e786
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68f74b5d06071d0008049616
😎 Deploy Preview https://deploy-preview-12507--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Oct 5, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/publish-to-npm.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@trueberryless
Copy link
Contributor

I am opposed to these changes as they currently are, because the term NPM occurs much more frequently than just in this file. Here is a list of all occurences of just the English documentation:

npm_mentions.md

One possibility would be to make it lowercase everywhere, but I think it should first be discussed if this is desired by maintainers.

@randomguy-2650
Copy link
Contributor Author

I’ll close this PR for now as this isn’t that important.

@sarah11918
Copy link
Member

sarah11918 commented Oct 21, 2025

Hi @randomguy-2650 !

I'm so sorry this PR didn't get attention quickly -- most of the core team was preparing for, then at ViteConf and some of us are still travelling/catching up! (And as you said, this wasn't putting out any fires, so we have had to prioritize recently, and this just hadn't made the cut yet. 😅 )

I think this is a perfectly valid PR, and I would love to be able to give you Hacktoberfest credit, too! Ideally we'd fix the capitalization everywhere, but fixing it in the page about publishing to npm seems like a good place to start! Fixing one page is certainly #NWTWWHB (Not Worse Than What We Had Before).

If you'd like to reopen this PR, then I am happy to approve and merge it this week! Sorry again that it was just really bad timing for being able to give attention to a less-urgent PR. Just reopen if you want, I'll notice, and we'll get 'er done!

@sarah11918 sarah11918 changed the title docs(i18nIgnore): Fix brand name capitalisation (npm) in publish-to-npm.mdx docs: Fix brand name capitalisation (npm) in publish-to-npm.mdx Oct 21, 2025
@sarah11918
Copy link
Member

Removing the i18nIgnore as it's likely most languages should at least check for this! I suspect most will need updating. (They should, if they follow our rules about copying the English exactly, even when we're wrong! 😅 )

@sarah11918 sarah11918 added hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest consistency/formatting Standardizing without changing docs content e.g. indenting, lists etc. labels Oct 21, 2025
@sarah11918 sarah11918 merged commit 5e6a8e3 into withastro:main Oct 21, 2025
10 checks passed
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Oct 21, 2025
@randomguy-2650 randomguy-2650 deleted the patch-4 branch October 21, 2025 14:32
HiDeoo added a commit to HiDeoo/docs that referenced this pull request Oct 23, 2025
* main: (107 commits)
  i18n(zh-cn): Update `markdown-content.mdx` (withastro#12580)
  i18n(zh-tw): update `basics/astro-components.mdx` (withastro#12592)
  i18n(fr): update `recipes/bun.mdx` (withastro#12595)
  i18n(ko-KR): update `publish-to-npm.mdx` (withastro#12599)
  i18n(fr): update `reference/publish-to-npm.mdx` (withastro#12600)
  docs: Fix brand name capitalisation (npm) in `publish-to-npm.mdx` (withastro#12507)
  chore(deps): update dependency node to v22.21.0 (withastro#12598)
  i18n(fr): update `experimental-flags/live-content-collections.mdx` (withastro#12593)
  i18n(fr): update code snippet in `guides/testing.mdx` (withastro#12594)
  i18n(ko-KR): update `testing.mdx` (withastro#12589)
  ci: update docs contributors (withastro#12590)
  Update Vitest reference type in testing guide (withastro#12588)
  i18n(ja): recipes/build-forms-api (withastro#12421)
  i18n(ko-KR): update `live-content-collections.mdx` (withastro#12585)
  i18n(ko-KR): update `bun.mdx` (withastro#12586)
  Remove `maxAge` from live collection docs (withastro#12571)
  i18n(zh-cn): Update `fonts.mdx` (withastro#12526)
  i18n(zh-cn): Update `content-collections.mdx` (withastro#12531)
  i18n(de): Update “Why Astro?” with “better” German typography [i18nIgnore] (withastro#12538)
  i18n(zh-tw): update `editor-setup.mdx` (withastro#12573)
  ...
HiDeoo added a commit to HiDeoo/docs that referenced this pull request Oct 23, 2025
* main: (107 commits)
  i18n(zh-cn): Update `markdown-content.mdx` (withastro#12580)
  i18n(zh-tw): update `basics/astro-components.mdx` (withastro#12592)
  i18n(fr): update `recipes/bun.mdx` (withastro#12595)
  i18n(ko-KR): update `publish-to-npm.mdx` (withastro#12599)
  i18n(fr): update `reference/publish-to-npm.mdx` (withastro#12600)
  docs: Fix brand name capitalisation (npm) in `publish-to-npm.mdx` (withastro#12507)
  chore(deps): update dependency node to v22.21.0 (withastro#12598)
  i18n(fr): update `experimental-flags/live-content-collections.mdx` (withastro#12593)
  i18n(fr): update code snippet in `guides/testing.mdx` (withastro#12594)
  i18n(ko-KR): update `testing.mdx` (withastro#12589)
  ci: update docs contributors (withastro#12590)
  Update Vitest reference type in testing guide (withastro#12588)
  i18n(ja): recipes/build-forms-api (withastro#12421)
  i18n(ko-KR): update `live-content-collections.mdx` (withastro#12585)
  i18n(ko-KR): update `bun.mdx` (withastro#12586)
  Remove `maxAge` from live collection docs (withastro#12571)
  i18n(zh-cn): Update `fonts.mdx` (withastro#12526)
  i18n(zh-cn): Update `content-collections.mdx` (withastro#12531)
  i18n(de): Update “Why Astro?” with “better” German typography [i18nIgnore] (withastro#12538)
  i18n(zh-tw): update `editor-setup.mdx` (withastro#12573)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consistency/formatting Standardizing without changing docs content e.g. indenting, lists etc. hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants