-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs: Fix brand name capitalisation (npm) in publish-to-npm.mdx
#12507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
I am opposed to these changes as they currently are, because the term One possibility would be to make it lowercase everywhere, but I think it should first be discussed if this is desired by maintainers. |
|
I’ll close this PR for now as this isn’t that important. |
|
Hi @randomguy-2650 ! I'm so sorry this PR didn't get attention quickly -- most of the core team was preparing for, then at ViteConf and some of us are still travelling/catching up! (And as you said, this wasn't putting out any fires, so we have had to prioritize recently, and this just hadn't made the cut yet. 😅 ) I think this is a perfectly valid PR, and I would love to be able to give you Hacktoberfest credit, too! Ideally we'd fix the capitalization everywhere, but fixing it in the page about publishing to npm seems like a good place to start! Fixing one page is certainly #NWTWWHB (Not Worse Than What We Had Before). If you'd like to reopen this PR, then I am happy to approve and merge it this week! Sorry again that it was just really bad timing for being able to give attention to a less-urgent PR. Just reopen if you want, I'll notice, and we'll get 'er done! |
publish-to-npm.mdxpublish-to-npm.mdx
|
Removing the |
* main: (107 commits) i18n(zh-cn): Update `markdown-content.mdx` (withastro#12580) i18n(zh-tw): update `basics/astro-components.mdx` (withastro#12592) i18n(fr): update `recipes/bun.mdx` (withastro#12595) i18n(ko-KR): update `publish-to-npm.mdx` (withastro#12599) i18n(fr): update `reference/publish-to-npm.mdx` (withastro#12600) docs: Fix brand name capitalisation (npm) in `publish-to-npm.mdx` (withastro#12507) chore(deps): update dependency node to v22.21.0 (withastro#12598) i18n(fr): update `experimental-flags/live-content-collections.mdx` (withastro#12593) i18n(fr): update code snippet in `guides/testing.mdx` (withastro#12594) i18n(ko-KR): update `testing.mdx` (withastro#12589) ci: update docs contributors (withastro#12590) Update Vitest reference type in testing guide (withastro#12588) i18n(ja): recipes/build-forms-api (withastro#12421) i18n(ko-KR): update `live-content-collections.mdx` (withastro#12585) i18n(ko-KR): update `bun.mdx` (withastro#12586) Remove `maxAge` from live collection docs (withastro#12571) i18n(zh-cn): Update `fonts.mdx` (withastro#12526) i18n(zh-cn): Update `content-collections.mdx` (withastro#12531) i18n(de): Update “Why Astro?” with “better” German typography [i18nIgnore] (withastro#12538) i18n(zh-tw): update `editor-setup.mdx` (withastro#12573) ...
* main: (107 commits) i18n(zh-cn): Update `markdown-content.mdx` (withastro#12580) i18n(zh-tw): update `basics/astro-components.mdx` (withastro#12592) i18n(fr): update `recipes/bun.mdx` (withastro#12595) i18n(ko-KR): update `publish-to-npm.mdx` (withastro#12599) i18n(fr): update `reference/publish-to-npm.mdx` (withastro#12600) docs: Fix brand name capitalisation (npm) in `publish-to-npm.mdx` (withastro#12507) chore(deps): update dependency node to v22.21.0 (withastro#12598) i18n(fr): update `experimental-flags/live-content-collections.mdx` (withastro#12593) i18n(fr): update code snippet in `guides/testing.mdx` (withastro#12594) i18n(ko-KR): update `testing.mdx` (withastro#12589) ci: update docs contributors (withastro#12590) Update Vitest reference type in testing guide (withastro#12588) i18n(ja): recipes/build-forms-api (withastro#12421) i18n(ko-KR): update `live-content-collections.mdx` (withastro#12585) i18n(ko-KR): update `bun.mdx` (withastro#12586) Remove `maxAge` from live collection docs (withastro#12571) i18n(zh-cn): Update `fonts.mdx` (withastro#12526) i18n(zh-cn): Update `content-collections.mdx` (withastro#12531) i18n(de): Update “Why Astro?” with “better” German typography [i18nIgnore] (withastro#12538) i18n(zh-tw): update `editor-setup.mdx` (withastro#12573) ...
Description (required)
This PR fixes the brand name capitalisation of npm in https://docs.astro.build/en/reference/publish-to-npm.
Note
Despite adding i18nIgnore in the title, it might need to be updated in all the other languages that have this page (that at least aren’t outdated).
npm capitalisation source: https://github.com/npm/cli?tab=readme-ov-file#is-it-npm-or-npm-or-npm
Related issues & labels (optional)
Hacktoberfest 🎃