Document custom mode support #9641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
added
add new content
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarah11918
added
the
merge-on-release
sarah11918
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Looks great! @bluwy! I stole a bit from the PR changeset, and I think the environment variable stuff should become its own smaller section AFTER introducing variables in general (maybe we even give it a sub heading? ), so see what you think!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Looks great @bluwy ! Just had a question about adding more info in the CLI reference page. I'm not sure myself, so I'll leave it to you!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
added
the
Merge Queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Add documentation for custom mode support. You can now pass any string to
--modeand themodeinline config.It also adds the
--devOutputflag support forastro buildto output a development-based build. Previously I don't believe there's an easy way, even if you had set--mode development(it may only partially work).This is a feature and shouldn't have any breaking changes, so there's no entry in the migration guide.
Related issues & labels (optional)
For Astro version:
5.0. See astro PR withastro/astro#12150