This repository was archived by the owner on Oct 11, 2022. It is now read-only.
E2e against ssr #2190
Closed
E2e against ssr #2190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help us catch more errors in our server-side rendering
setup. (like infinite loops)
This requires an update to our Codeship config, don't be surprised if
the tests fail here at first!
Closes #2132
brianlovin
approved these changes
Dec 12, 2017
Contributor
Author
|
Gotta update the codeship test config first, which will clash with any other open PR, so will finish while you're sleeping tomorrow most likely. |
Contributor
|
Kk. Can we push through #2162 even if it fails? |
Contributor
Author
|
Way out of date and replaced with #2843 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help us catch more errors in our server-side rendering setup. (like infinite loops) This requires an update to our Codeship config, don't be surprised if the tests fail here at first!
This is also based on #2183, so until that's merged you'll see those changes in this branch too.
Closes #2132
After merging