This repository was archived by the owner on Oct 11, 2022. It is now read-only.
fix:(src,api,hyperion) Remove all unused maintenance mode code #3087 #3123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianlovin
previously approved these changes
May 20, 2018
Contributor
brianlovin
left a comment
brianlovin
left a comment
There was a problem hiding this comment.
LGTM, will let Max get final approval here that this is no longer needed!
Contributor
Author
|
@mxstbr remove bunch of revert commit & merged master. |
mxstbr
approved these changes
May 29, 2018
Contributor
mxstbr
left a comment
mxstbr
left a comment
There was a problem hiding this comment.
This LGTM, thank you so much!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
overview
fixed https://github.com/withspectrum/spectrum/issues/3087.
i confirmed webclientside, ssr, api were still work without error with running these jobs.
yarn dev:api,yarn dev:web,yarn dev:dev:hyperionand contain tweek codebase fix commits.It has been revertted because there are many differences and the review has become serious. Open PR individually.thanks🙏