This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Flaky cypress test #3168
Merged
Flaky cypress test #3168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxstbr
approved these changes
May 29, 2018
Contributor
mxstbr
left a comment
mxstbr
left a comment
There was a problem hiding this comment.
Ohh thank you so much for digging into that! ❤️
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny PR: was looking through the E2E tests and this one kept failing locally. If it wasn't failing the CI build previously, I imagine it's due to a difference in machine specs.
Problem was that the
cy.get('[data-cy="join-community-button"]').should('be.disabled');was getting invoked too late. Sequence that occurred:Sometimes happened on the first
.should('be.disabled'), sometimes on the second. With the changes, haven't experienced any failures.Screenshot of failure prior to change:
Status
Deploy after merge (delete what needn't be deployed)
N/A