Skip to content
This repository was archived by the owner on Oct 11, 2022. It is now read-only.

Fix flaky e2e tests #3169

Merged
merged 1 commit into from
May 29, 2018
Merged

Fix flaky e2e tests #3169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions cypress/integration/channel/settings/edit_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ describe('edit a channel', () => {
.should('be.visible')
.click();

cy.get('[data-cy="save-button"]').should('be.disabled');

cy.get('[data-cy="save-button"]').should('not.be.disabled');

cy.visit(`/${community.slug}/${channel.slug}`);
cy.get('[data-cy="channel-profile-full"]').should('be.visible');
cy.get('[data-cy="channel-profile-full"]').contains(NEW_NAME);
Expand Down
8 changes: 0 additions & 8 deletions cypress/integration/channel/view/membership_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ const leave = () => {

cy.get('[data-cy="channel-join-button"]').click();

cy.get('[data-cy="channel-join-button"]').should('be.disabled');

cy.get('[data-cy="channel-join-button"]').should('not.be.disabled');

cy.get('[data-cy="channel-join-button"]').contains(`Join `);
};

Expand All @@ -50,10 +46,6 @@ const join = () => {

cy.get('[data-cy="channel-join-button"]').click();

cy.get('[data-cy="channel-join-button"]').should('be.disabled');

cy.get('[data-cy="channel-join-button"]').should('not.be.disabled');

cy.get('[data-cy="channel-join-button"]').contains(`Joined`);
};

Expand Down
3 changes: 0 additions & 3 deletions cypress/integration/community/settings/private_invite_link_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@ describe('private community invite link settings', () => {

cy.get('[data-cy="refresh-join-link-token"]').click();

cy.get('[data-cy="refresh-join-link-token"]').should('be.disabled');
cy.get('[data-cy="refresh-join-link-token"]').should('not.be.disabled');

// grab the input again and compare its previous value
// to the current value
cy
Expand Down
4 changes: 0 additions & 4 deletions cypress/integration/thread/action_bar_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,6 @@ describe('action bar renders', () => {
.clear()
.type(title);
cy.get('[data-cy="save-thread-edit-button"]').click();
cy.get('[data-cy="save-thread-edit-button"]').should('be.disabled');
cy.get('[data-cy="save-thread-edit-button"]').should('not.be.disabled');
cy.get('[data-cy="thread-view"]');
cy.contains(title);

Expand All @@ -212,8 +210,6 @@ describe('action bar renders', () => {
.clear()
.type(originalTitle);
cy.get('[data-cy="save-thread-edit-button"]').click();
cy.get('[data-cy="save-thread-edit-button"]').should('be.disabled');
cy.get('[data-cy="save-thread-edit-button"]').should('not.be.disabled');
cy.get('[data-cy="thread-view"]');
cy.contains('The first thread! 🎉');
});
Expand Down