This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Bug bash day #3188
Merged
Bug bash day #3188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianlovin
changed the title
Generated by 🚫 dangerJS |
Contributor
Author
|
Kk this is ready for review + discussion @mxstbr - each commit is pretty self contained. Let's discuss about:
|
Contributor
Yes, I looked into this but it's hard and not worth the effort atm imo.
I thought the point of |
Contributor
Author
I thought so, too :/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
Working through some sentry bugs.
f147761 => https://sentry.io/space-program/spectrum/issues/558113660/?query=is:unresolved
5e4479a => https://sentry.io/space-program/spectrum/issues/564742242/?query=is:unresolved
a3be231 => https://sentry.io/space-program/spectrum/issues/545394207/?query=is:unresolved and https://sentry.io/space-program/spectrum/issues/562870198/
cc @mxstbr ^^ => I don't want to go too far down the rabbit hole of supporting super old versions of IE, but we are seeing a fairly regular stream of bugs affecting edge and even IE11. We can simply extend the default polyfills provided by polyfill.io as seen in this commit, although I'm not sure what other things we'll have to keep adding to this over time. I spent a while this afternoon trying to find a more cohesive way to polyfill this kind of stuff, but obviously it just adds complexity if we try to keep bundle size small for users on modern browsers. The two added in this commit add a few hundred bytes for bugs affecting maybe a few dozen users. Wdyt?
Documentation: https://polyfill.io/v2/docs/examples#aliases
Actually, this is affecting hundreds of users: https://sentry.io/space-program/spectrum/issues/562170782/?query=is:unresolved
e4a3538 => https://sentry.io/space-program/spectrum/issues/565877960/?query=is:unresolved
0ad80a1 => https://sentry.io/space-program/spectrum/issues/530053952/events/21267481078/ - this one is pretty important as we have some invalid emails getting into our db which have been causing trouble in hermes (to the tune of 257 events in the last 30 days)
b50082d => https://sentry.io/space-program/spectrum/issues/513764806/?query=is:unresolved - @mxstbr let's chat about this one specifically. Any thoughts on how we could properly flowtype all of our loaders? Flow should have caught that we don't have an
isDeletedfield on aDBThread😅f706731 => this is a temporary fix to prevent https://sentry.io/space-program/spectrum/issues/566970820/?query=is:unresolved from crashing the frontend. Issue opened at https://github.com/withspectrum/spectrum/issues/3190 to discuss the proper fix
00d5808 => https://sentry.io/space-program/spectrum/issues/498612908/?query=is:unresolved - additionally I've improved some of the default behaviors when a person presses
escor clicks outside of the search results :)