This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Run desktop CD from the alpha branch #3221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As @brianlovin noticed in #3199, the CD for the desktop app wasn't working because CircleCI only runs builds for commits that are associated with a PR. While we could set CircleCI to run builds for all branches, that's a very suboptimal solution as it would run a ton of unnecessary builds. I came to wondering, why does the CD for alpha work if it doesn't build branches? Hidden in the CircleCI docs I found this snippet: > Note: For your default branch, we will always build all commits. Which explains why alpha CD works, but production CD doesn't. This patch is a very simple solution to this problem: we run desktop CD on the alpha branch. That is fine because the desktop CD only creates a draft GitHub release and we have to manually publish that release for anybody to get the update, so it doesn't matter if we CD from alpha or production!
Contributor
|
@mxstbr sounds fine with me, we'll just end up with a lot of drafts - not the end of the world. Tbh I didn't necessarily mind just doing |
brianlovin
approved these changes
May 31, 2018
Contributor
Author
It doesn't do that! It just updates the existing one until we hit publish on that |
Contributor
|
Oh, well that's ideal then! Good to know |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
As @brianlovin noticed in #3199, the CD for the desktop app wasn't working because CircleCI only runs builds for commits that are associated with a PR.
While we could set CircleCI to run builds for all branches, that's a very suboptimal solution as it would run a ton of unnecessary builds.
I came to wondering, why does the CD for alpha work if it doesn't build branches? Hidden in the CircleCI docs I found this snippet:
Which explains why alpha CD works, but production CD doesn't.
This patch is a very simple solution to this problem: we run desktop CD on the alpha branch. That is fine because the desktop CD only creates a draft GitHub release and we have to manually publish that release for anybody to get the update, so it doesn't matter if we CD from alpha or production!