This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Add standard right click menu to desktop app #3224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module by Sindre shows the standard right-click menu on right-click.
brianlovin
previously approved these changes
May 31, 2018
brianlovin
reviewed
May 31, 2018
| // Keep a global reference of the window object, if you don't, the window will | ||
| // be closed automatically when the JavaScript object is garbage collected. | ||
| // eslint-disable-next-line | ||
| let win; |
Contributor
There was a problem hiding this comment.
Why did you remove this line?
Contributor
Author
There was a problem hiding this comment.
Because win is unused in the entirety of the file lol
Contributor
Author
There was a problem hiding this comment.
I mean I can leave it there but the variable is unused.
Contributor
There was a problem hiding this comment.
I know it's unused - the comment above says to do that though? Idk
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
Closes #3184