This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Don't server-side render for desktop app #3227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The desktop app requests the same paths as the browser would, which means previously it would also get the server-side rendered HTML. The problem is that the server-side rendered frontend doesn't know that it's being rendered for the desktop app, and thusly renders the standard frontend, which looks crappy in the desktop app. This patch disables server-side rendering enterily when a req from the desktop app comes in, which fixes that issue.
Generated by 🚫 dangerJS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The desktop app requests the same paths as the browser would, which
means previously it would also get the server-side rendered HTML.
The problem is that the server-side rendered frontend doesn't know that
it's being rendered for the desktop app, and thusly renders the standard
frontend, which looks crappy in the desktop app.
This patch disables server-side rendering enterily when a req from the
desktop app comes in, which fixes that issue.
Status
Deploy after merge (delete what needn't be deployed)
Maybe fixes #3210