Skip to content
This repository was archived by the owner on Oct 11, 2022. It is now read-only.

Conversation

@brianlovin
Copy link
Contributor

Status

  • WIP
  • Ready for review
  • Needs testing

Deploy after merge (delete what needn't be deployed)

  • hyperion (frontend)
  • desktop

Closes #3234
Closes #3203

@mxstbr this does a few things:

  1. Ensures that all in-app links that point outside of Spectrum have target="_blank"
  2. Opens all links in the user's default browser. Note: I haven't figured out how to make it so that if the user command+clicks that it can open the browser in the background
  3. I added an escape hatch option in the menu to 'go home' - just in case someone gets into a scenario where their app is on some other url, they can press cmdOrCtrl+Shift+H to return back to the spectrum root - let me know if that makes sense for you!

@spectrum-bot
Copy link

spectrum-bot bot commented May 31, 2018

Warnings
⚠️

These modified files do not have Flow enabled:

  • src/components/linkPreview/index.js

Generated by 🚫 dangerJS

Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense to me, I like it!

@mxstbr mxstbr merged commit 4d928bb into alpha Jun 1, 2018
@mxstbr mxstbr deleted the open-all-desktop-app-links-in-browser branch June 1, 2018 08:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants